Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow singleton dynamic value injection and solves #330 #360

Merged
merged 7 commits into from
Sep 9, 2016
Merged

Allow singleton dynamic value injection and solves #330 #360

merged 7 commits into from
Sep 9, 2016

Conversation

remojansen
Copy link
Member

@remojansen remojansen commented Sep 7, 2016 •
edited
Loading

Description

Did some preparations required for #330 and completed #357

Related Issue

#357 & #330

Motivation and Context

#357 & #330

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the type definitions.
  • I have updated the type definitions accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@remojansen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @hourliert, @lukas-zech-software and @otbe to be potential reviewers

@remojansen remojansen changed the title Allow singleton dynamic value injection and preparation new typings distribution Allow singleton dynamic value injection and solves #330 Sep 8, 2016
This was referenced Sep 8, 2016
Closed
Closed
@remojansen
Copy link
Member Author

remojansen commented Sep 8, 2016 •
edited
Loading

This PR is blocked by TypeStrong/tsify#196

@remojansen remojansen merged commit a762e2b into inversify:master Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remojansen @mention-bot